Re: [PATCH] arm64: dts: qcom: talos: Add RPi Touch Display 2 5-inch overlay

[Konrad Dybcio]

On 8/27/26 10:58 AM, Abhishek Thomas Varghese wrote:
> Add a DT overlay to connect the Raspberry Pi Touch Display 2 5-inch
> panel to DSI0 on the Qualcomm IQ615/QCS615 EVK.
> 
> The overlay describes the display controller, panel, touch
> controller, power supplies, and backlight. Disable the ADV7511
> bridge to avoid a conflicting device on DSI virtual channel 0.
> 
> Display output, touch input, backlight control, and concurrent
> DisplayPort operation have been tested.
> 
> Signed-off-by: Abhishek Thomas Varghese <tessolveupstream@xxxxxxxxx>
> ---
> This single-patch series adds support for the Raspberry Pi Touch
> Display 2 5-inch panel on the Qualcomm IQ615/QCS615 Talos EVK.
> 
> The overlay describes the ILI9881C-based panel, Goodix GT911
> touchscreen, display controller, power supplies, and backlight.
> It also disables the ADV7511 bridge to avoid a conflicting device
> on DSI virtual channel 0.

Copy-pasting the commit message yet again doesn't add value to the
email

[...]

> +&i2c1 {
> +	clock-frequency = <400000>;
> +	status = "okay";

Let's uniformly keep an \n before 'status', file-wide> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	hdmi_bridge: bridge@3d {
> +		reg = <0x3d>;
> +		status = "disabled";
> +	};

And let's not define new nodes with hopes that it will resolve to an existing
one. Let's just do:

&hdmi_bridge {
	status = "disabled";
};

Konrad