[PATCH v6 06/29] drm/msm/dp: add MST stream register definitions

From: Yongxing Mou

Date: Mon Aug 31 2026 - 04:19:05 EST


Add the stream-1 (DP1) and MST-link register definitions together with
msm_dp_stream_reg(), a helper that translates stream-0 register offsets
into their stream-specific equivalents.

Keeping the register definitions and translation helper together ensures
that all supported mappings are defined in one place.

Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 65 +++++++++++++++++++++++++++++++++++++++
drivers/gpu/drm/msm/dp/dp_panel.h | 2 ++
drivers/gpu/drm/msm/dp/dp_reg.h | 56 +++++++++++++++++++++++++++++++++
3 files changed, 123 insertions(+)

diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index 7b5fc5bb16de..504d7542d30a 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -29,6 +29,71 @@ struct msm_dp_panel_private {
bool panel_on;
};

+u32 msm_dp_stream_reg(enum msm_dp_stream_id id, u32 reg)
+{
+ bool is_s1 = (id == DP_STREAM_1);
+
+ if (id == DP_STREAM_0)
+ return reg;
+
+ switch (reg) {
+ case REG_DP_STATE_CTRL:
+ return is_s1 ? REG_DP_STATE_CTRL : REG_DP_MSTLINK_STATE_CTRL;
+ case REG_DP_CONFIGURATION_CTRL:
+ return is_s1 ? REG_DP1_CONFIGURATION_CTRL : REG_DP_MSTLINK_CONFIGURATION_CTRL;
+ case REG_DP_SOFTWARE_MVID:
+ return is_s1 ? REG_DP1_SOFTWARE_MVID : REG_DP_MSTLINK_SOFTWARE_MVID;
+ case REG_DP_SOFTWARE_NVID:
+ return is_s1 ? REG_DP1_SOFTWARE_NVID : REG_DP_MSTLINK_SOFTWARE_NVID;
+ case REG_DP_TOTAL_HOR_VER:
+ return is_s1 ? REG_DP1_TOTAL_HOR_VER : REG_DP_MSTLINK_TOTAL_HOR_VER;
+ case REG_DP_START_HOR_VER_FROM_SYNC:
+ return is_s1 ? REG_DP1_START_HOR_VER_FROM_SYNC
+ : REG_DP_MSTLINK_START_HOR_VER_FROM_SYNC;
+ case REG_DP_HSYNC_VSYNC_WIDTH_POLARITY:
+ return is_s1 ? REG_DP1_HSYNC_VSYNC_WIDTH_POLARITY
+ : REG_DP_MSTLINK_HSYNC_VSYNC_WIDTH_POLARITY;
+ case REG_DP_ACTIVE_HOR_VER:
+ return is_s1 ? REG_DP1_ACTIVE_HOR_VER : REG_DP_MSTLINK_ACTIVE_HOR_VER;
+ case REG_DP_MISC1_MISC0:
+ return is_s1 ? REG_DP1_MISC1_MISC0 : REG_DP_MSTLINK_MISC1_MISC0;
+ case REG_DP_DP0_TIMESLOT_1_32:
+ return is_s1 ? REG_DP_DP1_TIMESLOT_1_32 : REG_DP_MSTLINK_TIMESLOT_1_32;
+ case REG_DP_DP0_TIMESLOT_33_63:
+ return is_s1 ? REG_DP_DP1_TIMESLOT_33_63 : REG_DP_MSTLINK_TIMESLOT_33_63;
+ case REG_DP_DP0_RG:
+ return is_s1 ? REG_DP_DP1_RG : REG_DP_MSTLINK_DP_RG;
+ case MMSS_DP_SDP_CFG:
+ return is_s1 ? MMSS_DP1_SDP_CFG : MMSS_DP_MSTLINK_SDP_CFG;
+ case MMSS_DP_SDP_CFG2:
+ return is_s1 ? MMSS_DP1_SDP_CFG2 : MMSS_DP_MSTLINK_SDP_CFG2;
+ case MMSS_DP_SDP_CFG3:
+ return is_s1 ? MMSS_DP1_SDP_CFG3 : MMSS_DP_MSTLINK_SDP_CFG3;
+ case MMSS_DP_GENERIC0_0:
+ return is_s1 ? MMSS_DP1_GENERIC0_0 : MMSS_DP_MSTLINK_GENERIC0_0;
+ case MMSS_DP_GENERIC0_1:
+ return is_s1 ? MMSS_DP1_GENERIC0_1 : MMSS_DP_MSTLINK_GENERIC0_1;
+ case MMSS_DP_GENERIC0_2:
+ return is_s1 ? MMSS_DP1_GENERIC0_2 : MMSS_DP_MSTLINK_GENERIC0_2;
+ case MMSS_DP_GENERIC0_3:
+ return is_s1 ? MMSS_DP1_GENERIC0_3 : MMSS_DP_MSTLINK_GENERIC0_3;
+ case MMSS_DP_GENERIC0_4:
+ return is_s1 ? MMSS_DP1_GENERIC0_4 : MMSS_DP_MSTLINK_GENERIC0_4;
+ case MMSS_DP_GENERIC0_5:
+ return is_s1 ? MMSS_DP1_GENERIC0_5 : MMSS_DP_MSTLINK_GENERIC0_5;
+ case MMSS_DP_GENERIC0_6:
+ return is_s1 ? MMSS_DP1_GENERIC0_6 : MMSS_DP_MSTLINK_GENERIC0_6;
+ case MMSS_DP_GENERIC0_7:
+ return is_s1 ? MMSS_DP1_GENERIC0_7 : MMSS_DP_MSTLINK_GENERIC0_7;
+ case MMSS_DP_GENERIC0_8:
+ return is_s1 ? MMSS_DP1_GENERIC0_8 : MMSS_DP_MSTLINK_GENERIC0_8;
+ case MMSS_DP_GENERIC0_9:
+ return is_s1 ? MMSS_DP1_GENERIC0_9 : MMSS_DP_MSTLINK_GENERIC0_9;
+ default:
+ return reg;
+ }
+}
+
static inline u32 msm_dp_read_link(struct msm_dp_panel_private *panel, u32 offset)
{
return readl_relaxed(panel->link_base + offset);
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h b/drivers/gpu/drm/msm/dp/dp_panel.h
index 218a09a2fa65..75b23c106a99 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.h
+++ b/drivers/gpu/drm/msm/dp/dp_panel.h
@@ -99,6 +99,8 @@ static inline bool is_lane_count_valid(u32 lane_count)
lane_count == 4);
}

+u32 msm_dp_stream_reg(enum msm_dp_stream_id id, u32 reg);
+
struct msm_dp_panel *msm_dp_panel_get(struct device *dev, struct drm_dp_aux *aux,
struct msm_dp_link *link,
void __iomem *link_base,
diff --git a/drivers/gpu/drm/msm/dp/dp_reg.h b/drivers/gpu/drm/msm/dp/dp_reg.h
index dda4b642c81b..265da58e064c 100644
--- a/drivers/gpu/drm/msm/dp/dp_reg.h
+++ b/drivers/gpu/drm/msm/dp/dp_reg.h
@@ -302,6 +302,35 @@
#define MMSS_DP_VSCEXT_8 (0x000002F0)
#define MMSS_DP_VSCEXT_9 (0x000002F4)

+/* Stream 1 (DP1) registers, relative to link_base. */
+#define REG_DP1_CONFIGURATION_CTRL (0x00000400)
+#define REG_DP_DP0_TIMESLOT_1_32 (0x00000404)
+#define REG_DP_DP0_TIMESLOT_33_63 (0x00000408)
+#define REG_DP_DP1_TIMESLOT_1_32 (0x0000040C)
+#define REG_DP_DP1_TIMESLOT_33_63 (0x00000410)
+#define REG_DP1_SOFTWARE_MVID (0x00000414)
+#define REG_DP1_SOFTWARE_NVID (0x00000418)
+#define REG_DP1_TOTAL_HOR_VER (0x0000041c)
+#define REG_DP1_START_HOR_VER_FROM_SYNC (0x00000420)
+#define REG_DP1_HSYNC_VSYNC_WIDTH_POLARITY (0x00000424)
+#define REG_DP1_ACTIVE_HOR_VER (0x00000428)
+#define REG_DP1_MISC1_MISC0 (0x0000042c)
+#define MMSS_DP1_GENERIC0_0 (0x00000490)
+#define MMSS_DP1_GENERIC0_1 (0x00000494)
+#define MMSS_DP1_GENERIC0_2 (0x00000498)
+#define MMSS_DP1_GENERIC0_3 (0x0000049c)
+#define MMSS_DP1_GENERIC0_4 (0x000004a0)
+#define MMSS_DP1_GENERIC0_5 (0x000004a4)
+#define MMSS_DP1_GENERIC0_6 (0x000004a8)
+#define MMSS_DP1_GENERIC0_7 (0x000004ac)
+#define MMSS_DP1_GENERIC0_8 (0x000004b0)
+#define MMSS_DP1_GENERIC0_9 (0x000004b4)
+#define MMSS_DP1_SDP_CFG (0x000004e0)
+#define MMSS_DP1_SDP_CFG2 (0x000004e4)
+#define MMSS_DP1_SDP_CFG3 (0x000004e8)
+#define REG_DP_DP0_RG (0x000004f8)
+#define REG_DP_DP1_RG (0x000004fc)
+
#define MMSS_DP_BIST_ENABLE (0x00000000)
#define DP_BIST_ENABLE_DPBIST_EN (0x00000001)

@@ -334,6 +363,33 @@
#define DP_TPG_VIDEO_CONFIG_BPP_8BIT (0x00000001)
#define DP_TPG_VIDEO_CONFIG_RGB (0x00000004)

+/* Streams 2/3 registers, relative to mst2link_base / mst3link_base. */
+#define REG_DP_MSTLINK_STATE_CTRL (0x00000000)
+#define REG_DP_MSTLINK_CONFIGURATION_CTRL (0x00000034)
+#define REG_DP_MSTLINK_TIMESLOT_1_32 (0x00000038)
+#define REG_DP_MSTLINK_TIMESLOT_33_63 (0x0000003c)
+#define REG_DP_MSTLINK_SOFTWARE_MVID (0x00000040)
+#define REG_DP_MSTLINK_SOFTWARE_NVID (0x00000044)
+#define REG_DP_MSTLINK_TOTAL_HOR_VER (0x00000048)
+#define REG_DP_MSTLINK_START_HOR_VER_FROM_SYNC (0x0000004c)
+#define REG_DP_MSTLINK_HSYNC_VSYNC_WIDTH_POLARITY (0x00000050)
+#define REG_DP_MSTLINK_ACTIVE_HOR_VER (0x00000054)
+#define REG_DP_MSTLINK_MISC1_MISC0 (0x00000058)
+#define MMSS_DP_MSTLINK_GENERIC0_0 (0x000000bc)
+#define MMSS_DP_MSTLINK_GENERIC0_1 (0x000000c0)
+#define MMSS_DP_MSTLINK_GENERIC0_2 (0x000000c4)
+#define MMSS_DP_MSTLINK_GENERIC0_3 (0x000000c8)
+#define MMSS_DP_MSTLINK_GENERIC0_4 (0x000000cc)
+#define MMSS_DP_MSTLINK_GENERIC0_5 (0x000000d0)
+#define MMSS_DP_MSTLINK_GENERIC0_6 (0x000000d4)
+#define MMSS_DP_MSTLINK_GENERIC0_7 (0x000000d8)
+#define MMSS_DP_MSTLINK_GENERIC0_8 (0x000000dc)
+#define MMSS_DP_MSTLINK_GENERIC0_9 (0x000000e0)
+#define MMSS_DP_MSTLINK_SDP_CFG (0x0000010c)
+#define MMSS_DP_MSTLINK_SDP_CFG2 (0x00000110)
+#define MMSS_DP_MSTLINK_SDP_CFG3 (0x00000114)
+#define REG_DP_MSTLINK_DP_RG (0x0000011C)
+
#define MMSS_DP_ASYNC_FIFO_CONFIG (0x00000088)

#define REG_DP_PHY_AUX_INTERRUPT_CLEAR (0x0000004C)

--
2.43.0