Re: [PATCH v1 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384

[Andy Chang]

On Fri, Aug 28, 2026 at 12:38 AM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Thu, Aug 27, 2026 at 07:02:41PM +0800, Andy Chang wrote:
> > Add the brcm,bcm4384-bt compatible string to support the
> > Synaptics BCM4384 Bluetooth controller.
>
> Please explain why a fallback compatible is not suitable here, or
> alternatively if it is, use one.
>
> pw-bot: changes-requested
>
> Thanks,
> Conor.
Hi Conor,
A fallback compatible is not suitable here because the BCM4384
controller requires a dedicated firmware patch file (.hcd) matching
its specific hardware ID and revision.
Falling back to an existing compatible would cause the driver to
request the wrong firmware binary and fail the controller
initialization.
Therefore, it requires a distinct compatible string.

>
> >
> > Signed-off-by: Andy Chang <andy.chang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> > index 95501e858e6f..612d21123aaa 100644
> > --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> > +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> > @@ -31,6 +31,7 @@ properties:
> >            - brcm,bcm43540-bt
> >            - brcm,bcm4335a0
> >            - brcm,bcm4349-bt
> > +          - brcm,bcm4384-bt
> >            - cypress,cyw4373a0-bt
> >            - infineon,cyw55572-bt
> >
> > --
> > 2.25.1
> >