Re: [PATCH v4 09/15] media: intel: ipu-bridge: allow sensor-specific link frequencies

[Andy Shevchenko]

On Fri, Aug 28, 2026 at 06:14:51PM +0200, Maurizio Casciano wrote:
> A bridge-specific firmware parser may have more accurate link-frequency
> information than the generic ACPI hardware-ID table. Let it store link
> frequencies in the per-sensor bridge data and prefer those values when
> constructing the endpoint software node.
> 
> Existing bridges continue to use the hardware-ID table when no
> sensor-specific frequencies are supplied.

...

> Link: https://lore.kernel.org/linux-media/apFzAc5XfV9gQpXS@kekkonen.localdomain/

Drop this.

...

> struct ipu_sensor {

We need to use common sense, AI sometimes produces a crap.

>  	u8 link;
>  	u8 lanes;
> +	u8 nr_link_freqs;
>  	u32 mclkspeed;
>  	u32 rotation;
>  	enum v4l2_fwnode_orientation orientation;
>  	const char *vcm_type;
> +	u64 link_freqs[MAX_NUM_LINK_FREQS];

I would orginise it as

	u64 link_freqs[MAX_NUM_LINK_FREQS];
	u8 nr_link_freqs;

// blank line here

	u8 link;
	u8 lanes;
	u32 mclkspeed;
	u32 rotation;
	enum v4l2_fwnode_orientation orientation;
	const char *vcm_type;


>  	struct ipu_property_names prop_names;
>  	struct property_entry ep_properties[5];

-- 
With Best Regards,
Andy Shevchenko