Re: [PATCH v4 10/15] media: atomisp: derive CSI-2 timing from sensor link frequency

[Andy Shevchenko]

On Fri, Aug 28, 2026 at 06:14:52PM +0200, Maurizio Casciano wrote:
> The ISP2401 CSI-2 receiver timing depends on the sensor link frequency.
> Query it through v4l2_get_link_freq() instead of reading a 32-bit
> control value directly.
> 
> Keep the frequency as s64 throughout the calculation so valid link
> frequencies do not require an arbitrary S32_MAX limit. Fall back to the
> existing default timings when the frequency query fails.

...

> Link: https://lore.kernel.org/linux-media/apFzAc5XfV9gQpXS@kekkonen.localdomain/

Drop this.

...

> static void atomisp_csi2_configure_isp2401(struct atomisp_sub_device *asd)

>  	int dat_termen;
>  	int dat_settle;
>  
> -	struct v4l2_control ctrl;
>  	struct atomisp_device *isp = asd->isp;
> -	int mipi_freq = 0;
> +	struct v4l2_subdev *sensor;
> +	s64 mipi_freq;

Move it one line below, ...

>  	enum atomisp_camera_port port;

...to here.

>  	int n;

...

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko