Re: [PATCH v4 12/15] media: ov2740: add manual white balance controls

[Andy Shevchenko]

On Fri, Aug 28, 2026 at 06:14:54PM +0200, Maurizio Casciano wrote:
> The sensor has separate red, green and blue manual white-balance gain
> registers, but the driver currently writes the same digital-gain value
> to all three channels. This prevents userspace from correcting the
> strong color cast of raw Bayer capture.
> 
> Expose red- and blue-balance controls relative to the digital gain,
> update all three channels under group hold,

> and always release and launch the group even when a channel write fails.

This part can be split to a separate change explaining "why?". What's wrong
if we don't do this (as it's currently done in the original code)?

> Tested on the Yoga Book OV2740 with live gain changes and continuous raw
> capture.

-- 
With Best Regards,
Andy Shevchenko