Re: [PATCH net 1/2] net: macb: exclude software FCS from TX byte statistics

[Nicolai Buchwitz]

Hi David

On 28.8.2026 15:02, David Laight wrote:
> On Fri, 28 Aug 2026 10:20:24 +0200

> [...]

> > > Either way, you only need u8 or even a flag for this,
> > > not a full u32?
> >
> > Agreed. skb->len at completion should already do the trick (minus
> > ETH_FCS_LEN).
> > So a flag would be sufficient.
>
> If you make the 'flag' 0 or 4 it will save some maths (and maybe a 
> branch)
> in the completion code.

I will make tx_skb->fcs_len hold 0 or ETH_FCS_LEN directly, so 
completion becomes
a skb->len - tx_skb->fcs_len. Anyway, I will split the patch into its 
own
as suggested by Paolo and you.

> [...]

Thanks
Nicolai