Re: [PATCH 1/4] USB: usbfs: replace __get_free_page() with kmalloc()

From: Oliver Neukum

Date: Mon Aug 31 2026 - 09:35:44 EST


On 30.08.26 10:10, Mike Rapoport (Microsoft) wrote:
do_proc_control() allocates a temporary buffer for the data stage of a
control transfer issued from userspace.

This buffer can be allocated with kmalloc() as there's nothing special
about it to go directly to the page allocator.

You are breaking the calculation. A page has a size of exactly
PAGE_SIZE. A kmalloced object of PAGE_SIZE is larger. That is
a bad idea.

Regards
Oliver