Re: [PATCH v4 05/15] media: ov8858: Add INT3477 ACPI ID

[Andy Shevchenko]

On Mon, Aug 31, 2026 at 01:12:41PM +0000, mauriziocasciano7@xxxxxxxxx wrote:
> Hi Andy, Sakari,
> 
> Thank you. The use of ACPI_PTR() in v4 was intentional and followed
> Sakari's explicit request in the v2 review:
> 
>   "Please use ACPI_PTR() for this one."
> 
> That review also referred to:
> 
>   https://lore.kernel.org/linux-media/20260828084328.257703-1-sakari.ailus@xxxxxxxxxxxxxxx/T/#t
> 
> Andy subsequently noted that the last patch in that related series was
> controversial and had been NAKed. I should have called out this conflict
> explicitly when sending v4 instead of leaving the rationale undocumented.
> 
> For v5 I have retained ACPI_PTR() for now. Removing it unilaterally would
> discard an explicit media-maintainer request, while keeping it without
> clarification would ignore Andy's objection and would not earn his review
> tag.
> 
> Could you please confirm which form you want for v5 while the related
> ACPI_PTR() work is unresolved?
> 
>   .acpi_match_table = ACPI_PTR(ov8858_acpi_match),
> 
> or:
> 
>   .acpi_match_table = ov8858_acpi_match,
> 
> I will use the agreed form and will not send v5 until this point is
> settled.

Sakari is media maintainer, do how he says.

-- 
With Best Regards,
Andy Shevchenko