Re: [PATCH AUTOSEL 6.18] ASoC: rt1320: run the initialisation preset on the first hardware init

[Sergey Lebedev]

Author's ack for the AUTOSEL 6.18 pick of

  ASoC: rt1320: run the initialisation preset on the first hardware init
  upstream 9b30521074f01aff856f539c1241a48342b69f7c

Appropriate for stable, and the reason is narrow enough to state precisely.

Without it the RT1320 on the Microsoft Surface Pro 11 is left unprogrammed on
every boot: its SDCA function status reads 0x41 (NEWLY_ATTACHED |
FUNCTION_HAS_BEEN_RESET) and never sets FUNCTION_NEEDS_INITIALIZATION, so
rt1320_vc_preset() and the MCU patch load are skipped. rt712-sdca and
rt722-sdca already carry the first_hw_init fallback this adds.

On the risk side, which is what matters for a backport: the added condition can
only cause the preset to run where it would otherwise not have run at all. On
hardware that does set FUNCTION_NEEDS_INITIALIZATION the behaviour is
unchanged, so a later board revision carrying a different RT1320 -- which Bard
Liao noted is possible for this SKU -- is not exposed to anything new.

Tested on the affected hardware. With the patch the amplifier reports
RT1320_KR0_INT_READY=0x1f where it previously did not, and audio works.

Sergey Lebedev