Re: [PATCH v4 02/10] dt-bindings: iio: adc: support the TI ADS126x ADC family

[Conor Dooley]

On Sun, Aug 30, 2026 at 02:57:43AM +0100, Jonathan Cameron wrote:
> > > +
> > > +  clocks:
> > > +    maxItems: 1  
> > 
> > clock doesn't appear mandatory, what does it do?
> > 
> > > +
> > > +  '#io-channel-cells':
> > > +    minimum: 1
> > > +    maximum: 2  
> > 
> > What's the use case for actually setting this as a single cell? Kinda
> > confused by it.
> 
> Part dependent, but I think we should just make them both take the two
> parameters and have the value of one of those fixed to 0 for some parts.
> Probably easier to understand that way at least.

+  - if:
+      properties:
+        compatible:
+          contains:
+            const: ti,ads1263
+    then:
+      properties:
+        '#io-channel-cells':
+          minimum: 1
+          maximum: 2

This in particular is what I question. Two different devices having
different cells is fine, this one device allowing both? Nah. It should
be fixed to 2. The ads1262 should probably have it fixed to 1, as the
driver already does.

> 
> > 
> > Otherwise, quite frankly, the binding is too complicated for me! I'll
> > have to leave it up to the IIO folks to cover whether what's being done
> > is sane.
> 
> I'm rely on David to take a look :)
> 
> To me it looks mostly fine but a few odd corners where I'm not sure
> how things are supposed to work.
> 
> Jonathan
> 
> > 
> > Cheers,
> > Conor.
> >

Attachment: signature.asc
Description: PGP signature