Re: [PATCH 2/9] rust: hrtimer: add ArcHrTimerHandle::restart

From: Andreas Hindborg

Date: Mon Aug 31 2026 - 14:47:49 EST


"Mike Lothian" <mike@xxxxxxxxxxxxxx> writes:

Hi Mike,

Please note that HTML messages are rejected by lore.

> On Thu, 27 Aug 2026, Andreas Hindborg wrote:
>> The intention is that handlers use the `forward` method on the context
>> object in combination with return value `HrTimerRestart::Restart` to re
>> arm the timer.
>>
>> However, we found a data race in the face of concurrent `start`
>> operations, so we are solving that over at [1].
>
> You are right, and checking properly, the driver that motivated this does
> not need it: its callback already ends with
>
> ctx.forward_now(Delta::from_nanos(interval));
> HrTimerRestart::Restart
>
> and nothing anywhere calls the handle's restart(). I will drop this patch
> rather than carry an API with no user, and rebase the rest on your
> expires-v2 series.
>
> Thanks for the pointer.

You are welcome :)

Best regards,
Andreas Hindborg