Re: [PATCH] audit: use copied skb length in kauditd_send_multicast_skb()

From: Paul Moore

Date: Mon Aug 31 2026 - 15:05:42 EST


On Mon, Aug 24, 2026 at 6:25 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Aug 10, 2026 Ricardo Robaina <rrobaina@xxxxxxxxxx> wrote:
> >
> > The netlink header's nlmsg_len was being set using the original skb
> > instead of the local copy passed to nlmsg_multicast().
> >
> > While skb->len and copy->len are identical at this point following
> > skb_copy(), it is conceptually cleaner and safer to use the length
> > of the skb being actively modified and sent. Thus, this is a minor
> > cleanup only, no functional change expected.
> >
> > Signed-off-by: Ricardo Robaina <rrobaina@xxxxxxxxxx>
> > Reviewed-by: Bradley Morgan <include@xxxxxxxxx>
> > ---
> > kernel/audit.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks reasonable. Merged into audit/dev-staging, will be moved to
> audit/dev next week.

... now in audit/dev, thanks!

--
paul-moore.com