Re: [PATCH net v1] ptp: fix NULL deref when adjtime/adjfine are missing

From: Richard Cochran

Date: Mon Aug 31 2026 - 15:48:38 EST


On Thu, Aug 27, 2026 at 02:43:31PM +0800, Xuanqiang Luo wrote:

> However, the PTP hardware clock documentation explicitly states:
>     Clock drivers must implement all of the functions in the interface. If
>     a clock does not offer a particular ancillary feature, then the driver
>     should just return -EOPNOTSUPP from those functions.
>
> Link: https://docs.kernel.org/driver-api/ptp.html#writing-clock-drivers
>
> Therefore, iavf does not comply with this requirement, and fixing the
> issue in the iavf driver is more appropriate.

+1

Thanks,
Richard