Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

On 8/31/26 5:05 PM, Conor Dooley wrote:

Hello Conor,

> > > Sashiko comment here I believe is valid, the syntax here only works if
> > > there's only the listed compatible present. It doesn't work with
> > > fallbacks.
> >
> > This syntax is used all over the place ?
> >
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - $ref:
> > ahci-common.yaml#
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - if:
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-      properties:
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-        compatible:
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml:          contains:
>
>                                                                       ^^^^^^^^
> This is the key difference, you need "contains" for partial matches.

Uh ... right ... fixed in V5. Thank you.

> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-            enum:
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> > qcom,apq8064-ahci
> > Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> > qcom,ipq806x-ahci
> >
> > > pw-bot: changes-requested
> > >
> > > >        then:
> > > >          required:
> > > >            - "#clock-cells"
> > > > +        - "#address-cells"
> > > > +        - "#size-cells"
> > >
> > > else, false? But I'm also not sure what the benefit is of requiring
> > > addr/size cells when the child node is not?
> > The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
> > arm64: dts: st: Add STM32MP2 USB support .
>
> Right, but I was questioning why the properties describing the reg
> property in children is required when the children (and thus the reg
> property in them) were not made required.

Do you mean this patternProperties should be made required in here ?

"
+patternProperties:
+  "^phy@[0-9a-f]+$":
"

Could you please give me a hint how to do that ? git grep gives me nothing.