Re: [PATCH v15 07/16] atomic: Add atomic_cond_read_*_timeout()
From: bot+bpf-ci
Date: Mon Aug 31 2026 - 17:17:55 EST
> atomic: Add atomic_cond_read_*_timeout()
>
> Add atomic load wrappers, atomic_cond_read_*_timeout() and
> atomic64_cond_read_*_timeout() for the cond-load timeout interfaces.
>
> Also add a short description for the atomic_cond_read_{relaxed,acquire}(),
> and the atomic_cond_read_{relaxed,acquire}_timeout() interfaces.
The changelog states it will "add a short description" for these interfaces,
but looking at the actual changes, the documentation hunks only list the
function names under a new heading and insert the words "or conditional" into
an existing sentence.
Nothing in the patch explains what these operations do (spin-wait on a pointer
until a condition is true), what the timeout parameters mean, that the timeout
variants can return with the condition still false, or what ordering guarantees
the _relaxed vs _acquire variants provide.
Should the changelog be updated to say it lists the new operations in the API
section, or should a description matching what the changelog promises be added
to the SEMANTICS section of Documentation/atomic_t.txt?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/33438155296