Re: [PATCH v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout()
From: patchwork-bot+bluetooth
Date: Mon Aug 31 2026 - 17:30:52 EST
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>:
On Tue, 25 Aug 2026 10:01:45 +0800 you wrote:
> From: Gongwei Li <ligongwei@xxxxxxxxxx>
>
> wait_on_bit_timeout() returns 0 if the bit was cleared, -EINTR if the
> process received a signal and the mode permitted wake up on that signal,
> or -EAGAIN if the timeout elapsed. It never returns 1.
>
> Hence the check "err == 1" in mrvl_load_firmware() is dead code: when
> the waiting task is interrupted by a signal (-EINTR), the code falls
> into the "else if (err)" branch and misreports it as "Firmware request
> timeout" with -ETIMEDOUT instead of propagating -EINTR.
>
> [...]
Here is the summary with links:
- [v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout()
https://git.kernel.org/bluetooth/bluetooth-next/c/870187be2362
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html