Re: [PATCH v2 3/5] genirq: Export NMI APIs

[Doug Anderson]

Hi,

On Fri, Aug 28, 2026 at 6:00 PM Mayank Rungta <mrungta@xxxxxxxxxx> wrote:
>
> Currently, request_nmi(), free_nmi(), enable_nmi(), disable_nmi_nosync(),
> and disable_nmi() are restricted to built-in kernel code because they are
> not exported.
>
> Export these symbols with EXPORT_SYMBOL_GPL so loadable kernel modules can
> register and manage NMIs.
>
> Assisted-by: Antigravity:gemini
> Signed-off-by: Mayank Rungta <mrungta@xxxxxxxxxx>
> ---
>  kernel/irq/manage.c | 5 +++++
>  1 file changed, 5 insertions(+)

This is no different than v1, so you probably should have carried my
Reviewed-by tag:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Sashiko has feedback [1], but it seems to be mostly regugitating the
same feedback it had on patch #1. It also mentions that "`free_nmi()`
ignores the provided `dev_id` parameter", but (to me) that doesn't
seem like a big deal and is certainly not new.

[1] https://lore.kernel.org/all/20260829011550.ECF091F000E9@xxxxxxxxxxxxxxx/