Re: [PATCH 5/9] ntfs: Remove FGP_NOFS from __ntfs_inode_resident_attr_pwrite()

From: Namjae Jeon

Date: Mon Aug 31 2026 - 19:34:42 EST


On Sun, Aug 30, 2026 at 1:19 PM Matthew Wilcox (Oracle)
<willy@xxxxxxxxxxxxx> wrote:
>
> I do not believe that FGP_NOFS is needed here. This function is called
> from one place (ntfs_inode_attr_pwrite) which calls either this function
> or __ntfs_inode_non_resident_attr_pwrite(). The latter function does not
> use FGP_NOFS in its calls to allocate pagecaache memory, so it should not
> be needed here either. If it turns out to be needed by both functions,
> then we should use memalloc_nofs_save at a higher level to protect both
> of them.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
Thanks!