Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card
From: Detlev Casanova
Date: Mon Aug 31 2026 - 20:03:45 EST
On Monday, 31 August 2026 13:29:00 EDT Diederik de Haas wrote:
> On Mon Aug 31, 2026 at 4:20 PM CEST, Detlev Casanova wrote:
> > Rename the card from "HDMI" to "RK356x HDMI" so it identifies the SoC
> > in user-visible ALSA fields and no longer collides with the identical
> > "HDMI" string used by other Rockchip SoCs.
> >
> > Fixes: 697ee8546e241 ("arm64: dts: rockchip: Add HDMI audio nodes to
> > rk356x") Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx>
> > ---
> >
> > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index
> > a5832895bd39..98785c812fc4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
> >
> > hdmi_sound: hdmi-sound {
> >
> > compatible = "simple-audio-card";
> >
> > - simple-audio-card,name = "HDMI";
> > + simple-audio-card,name = "RK356x HDMI";
>
> Move the name property to rk3566.dtsi and rk3568.dtsi and use their actual
> SoC name, thus RK3566 and RK3568?
I hesitated on this one but I agree with you, it's better to have more
granularity. Will update in v2.
Detlev.
> Cheers,
> Diederik
>
> > simple-audio-card,format = "i2s";
> > simple-audio-card,mclk-fs = <256>;
> > status = "disabled";