Re: [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras

[Bjorn Andersson]

On Tue, Jul 21, 2026 at 02:36:49PM +0200, Konrad Dybcio wrote:
> On 7/21/26 2:33 PM, David Heidelberg via B4 Relay wrote:
> > From: David Heidelberg <david@xxxxxxx>
> > 
> > The Pixel 3 features two front-facing Sony IMX355 sensors with
> > different focal lengths (standard and wide-angle).
> > 
> > Sensors are connected via CSIPHY port 1 and 2 and controlled over CCI
> > I2C1, using MCLK2 as the clock source.
> > 
> > This enables support for the dual front camera configuration.
> > 
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 172 ++++++++++++++++++++-
> >  1 file changed, 171 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> > index 9368fd6b87515..c8a28133fb38d 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> > @@ -1,16 +1,18 @@
> >  // SPDX-License-Identifier: GPL-2.0-only
> >  
> >  /dts-v1/;
> >  
> >  #include <dt-bindings/arm/qcom,ids.h>
> >  #include <dt-bindings/dma/qcom-gpi.h>
> >  #include <dt-bindings/input/linux-event-codes.h>
> >  #include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/media/video-interfaces.h>
> > +#include <dt-bindings/media/video-interface-devices.h>
> 
> These should be flipped to be sorted.. if you smile very nicely,
> Bjorn could prob fix it up
> 

Sure can do, but I don't have dt-bindings/media/video-interface-devices.h :(

> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> 
> Konrad