Re: [PATCH v2 1/2] wifi: ath12k: support calibration-variant from device tree

[Baochen Qiang]

On 9/1/2026 4:09 AM, Jeff Johnson wrote:
> On 6/30/2026 6:30 AM, Andrew LaMarche wrote:
>> +int ath12k_core_check_dt(struct ath12k_base *ab)
>> +{
>> +	size_t max_len = sizeof(ab->qmi.target.bdf_ext);
>> +	const char *variant = NULL;
>> +	struct device_node *node;
>> +
>> +	node = ab->dev->of_node;
>> +	if (!node)
>> +		return -ENOENT;
>> +
>> +	of_property_read_string(node, "qcom,calibration-variant",
> 
> I've fixed the following in the pending branch:
>     ● checkpatch.pl: 126: CHECK: Alignment should match open parenthesis
> 
>> +			&variant);
>> +	if (!variant)
>> +		return -ENODATA;
>> +
>> +	if (strscpy(ab->qmi.target.bdf_ext, variant, max_len) < 0)
>> +		ath12k_dbg(ab, ATH12K_DBG_BOOT,
>> +				"bdf variant string is longer than the buffer can accommodate (variant: %s)\n", variant);
> 
> Also:
>     ● checkpatch.pl: 132: WARNING: line length of 121 exceeds 100 columns
>     ● checkpatch.pl: 132: CHECK: Alignment should match open parenthesis
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?id=c9d2d0d1c4a0faaba5f57e3c3350707db9f4f3f3

looks good to me.

> 
>> +
>> +	return 0;
>> +}
>> +
>