Re: [PATCH net-next v3 3/6] net: xilinx: axienet: Add 10G/25G (XXV) ethernet support

From: Gupta, Suraj

Date: Mon Aug 31 2026 - 23:27:45 EST




On 9/1/2026 8:22 AM, Andrew Lunn wrote:
+ /* This error handler runs only for the legacy embedded-DMA (1G) path,
+ * whose mac_init() cannot fail, so its return value is not checked.
+ */

Is legacy the correct word here. Have you stopped licensing the 1G
MAC?

Andrew

By "legacy embedded-DMA (1G) path", I meant the legacy non-dmaengine flow in the driver. This path does not use the dmaengine framework and therefore does not communicate with the Xilinx DMAEngine driver; instead, the AXI Ethernet driver handles the DMA programming directly.

I agree that "legacy embedded-DMA" could be confusing here. I'll rename it to "non-dmaengine flow" in the next revision.

Thanks,
Suraj