Re: [PATCH v4 3/3] Docs/mm/damon/design: Document hugepage_mem_bp target metric

[SJ Park]

On Tue, 1 Sep 2026 08:20:50 +0300 Gutierrez Asier <gutierrez.asier@xxxxxxxxxxxxxxxxxxx> wrote:

> On 9/1/2026 3:47 AM, SJ Park wrote:
> > On Mon, 31 Aug 2026 13:00:26 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> Hi,
> > 
> >>
> >>
> >> On 8/31/26 8:45 AM, Randy Dunlap wrote:
> >>> Hi,
> >>>
> >>> On 8/31/26 7:47 AM, SJ Park wrote:
> >>>> From: Asier Gutierrez <gutierrez.asier@xxxxxxxxxxxxxxxxxxx>
> >>>>
> >>>> Document hugepage_mem_bp metric exposed by sysfs.
> >>>>
> >>>> Signed-off-by: Asier Gutierrez <gutierrez.asier@xxxxxxxxxxxxxxxxxxx>
> >>>> Reviewed-by: SJ Park <sj@xxxxxxxxxx>
> >>>> Signed-off-by: SJ Park <sj@xxxxxxxxxx>
> >>>> ---
> >>>>  Documentation/mm/damon/design.rst | 2 ++
> >>>>  1 file changed, 2 insertions(+)
> >>>>
> >>>> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> >>>> index aed6cb1cf4831..a8c163475ef2b 100644
> >>>> --- a/Documentation/mm/damon/design.rst
> >>>> +++ b/Documentation/mm/damon/design.rst
> >>>> @@ -713,6 +713,8 @@ mechanism tries to make ``current_value`` of ``target_metric`` be same to
> >>>>    bp (1/10,000).
> >>>>  - ``node_eligible_mem_bp``: Scheme target access pattern-eligible memory ratio
> >>>>    of a node in bp (1/10,000).
> >>>> +- ``hugepage_mem_bp``: Total huge page to total used memory ratio in bp
> >>>> +  (1/10,000).
> >>>>  
> >>>>  ``nid`` is optionally required for ``node_mem_used_bp``, ``node_mem_free_bp``,
> >>>>  ``node_memcg_used_bp``, ``node_memcg_free_bp`` and ``node_eligible_mem_bp`` to
> >>>
> >>> I've looked thru the entire design.rst file and cannot find anything telling
> >>> me (or anyone) what "bp" means.  Explain??
> >>
> >> OK, I found it on the internet. I still think that it would be a
> >> good idea to say "basis point" one time (the first time that it is used).
> > 
> > You are right, and I agree.  I will add that clarification before the next
> > merge window.
> > 
> >>
> >>
> >> -- 
> >> ~Randy
> > 
> > 
> > Thanks,
> > SJ
> 
> SJ, should I submit a new patch to fix design.rst?

The lack of the clarification of 'bp' was introduced before this patch.  So I
don't think you should do that on your own.

Of course you could do if you want to.  But that should be a separate patch in
my opinion.  Let me know if you will.  Otherwise I will do.


Thanks,
SJ

[...]