Re: [PATCH RFC/DO NOT MERGE 09/12] drm/msm/hdmi: Add HDMI for Eliza SoC

[Krzysztof Kozlowski]

On 31/08/2026 18:45, Konrad Dybcio wrote:
> On 8/28/26 4:05 PM, Krzysztof Kozlowski wrote:
>> Qualcomm Eliza SoC with DPU v12.4 comes with HDMI on INTF_11 with
>> additional INTR registers.  The device clocks look different comparing
>> to last variant of HDMI from MSM8998.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>> ---
> 
> [...]
> 
>> +	hdmi->pixel_src_clk = devm_clk_get_optional(dev, "pixel_src");
>> +	if (IS_ERR(hdmi->pixel_src_clk)) {
>> +		ret = dev_err_probe(dev, PTR_ERR(hdmi->pixel_src_clk),
>> +				    "failed to get pixel src clock\n");
>> +		goto err_put_bridge;
>> +	}
> 
> Why do we need to toggle the source clock directly? Is the clock
> driver broken?

It's getting reference not for toggling - there is no prepare/enable.
It's getting for reparenting to solve the same problem DSI has -
assigned-clock-parents are reparenting to PHY PLLL before PHY is on
leading to stuck RCG.

Best regards,
Krzysztof