Re: [PATCH 2/6] dt-bindings: ptp: Document TSCSS hardware on Qualcomm QDU1000 SoC

[Imran Shaik]

On 27-07-2026 09:21 pm, Krzysztof Kozlowski wrote:
> On 27/07/2026 16:10, Imran Shaik wrote:
> > Add Devicetree bindings for the Timestamp Counter Subsystem (TSCSS) found
> > on Qualcomm QDU1000 SoC.
> >
> > TSCSS is a time synchronization subsystem composed of two main blocks:
> > Timestamp Counter (TSC) and Event Timestamp Unit (ETU). The TSC block
> > provides a continuously running counter used for timekeeping, while the
> > ETU captures timestamps for external hardware event triggers.
> >
> > Co-developed-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> > ---
> >   .../bindings/ptp/qcom,qdu1000-tscss.yaml           | 187 +++++++++++++++++++++
> >   1 file changed, 187 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/ptp/qcom,qdu1000-tscss.yaml b/Documentation/devicetree/bindings/ptp/qcom,qdu1000-tscss.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..39387614ef8939b7840df2f0d5640b9e142fb4e5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ptp/qcom,qdu1000-tscss.yaml
> > @@ -0,0 +1,187 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/ptp/qcom,qdu1000-tscss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Timestamp Counter Subsystem (TSCSS) on Qualcomm QDU1000 SoC
> > +
> > +maintainers:
> > +  - Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> > +  - Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> > +
> > +description: |
> > +  Qualcomm TSCSS is a time synchronization subsystem composed of two main
> > +  blocks - the Time Stamp Counter (TSC) and the Event Timestamp Unit (ETU).
> > +
> > +  The TSC block is a timestamp generator that maintains a running counter used
> > +  for system timekeeping, and is functional with just the AHB and counter
> > +  clocks.
> > +  The ETU block is optional and captures TSC timestamps for external
> > +  hardware events, each ETU slice binding a slice identifier to an external
> > +  event selector. Support for the ETU block requires the additional ETU
> > +  clock along with the per slice interrupt and slice subnodes.
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,qdu1000-tscss
>
> Why do you create a new file with exactly the same binding?

The QDU1000 SoC TSCSS has the per ETU slice IRQ lines. Where as in
Lemans/Monaco, it is summary IRQ line for all the ETU slices. Hence,
kept two different bindings for both the SoCs.

> Anyway, all comments apply.

Sure, will take care of those comments here as well.

Thanks,
Imran