Re: [PATCH v2 5/6] arm64: dts: qcom: qcs6490-thundercomm-minipc-g1iot: clean up PCI function nodes
From: Abel Vesa
Date: Tue Sep 01 2026 - 03:29:49 EST
On 26-08-31 20:36:52, Alex Elder wrote:
> The Thundercomm AI Mini PC G1 IoT devicetree source file defines a node
> representing a TC956x chip which contains a PCIe switch and an embedded
> endpoint that implements two PCIe functions.
>
> The devicetree nodes erroneously include a "pci" device_type property
> for the two PCIe functions. That property should only be used for a
> PCI device "that implements a PCI bus". Remove this property for the
> two function nodes.
>
> In addition, these nodes define #address-cells, #size-cells, and ranges
> properties, which are not normally defined for PCIe endpoints. Remove
> properties as well; they can be added back once they are actually
> needed/used.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Fixes: 1cde54c54b83b ("arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT")
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>