Re: [PATCH v2 1/6] arm64: dts: qcom: qcs6490-rb3gen2: clean up PCI function nodes

[Abel Vesa]

On 26-08-31 20:36:48, Alex Elder wrote:
> The TC9564 SoC contains a PCIe switch with three downstream ports.
> The third downstream port connects to an embedded PCI endpoint,
> and that endpoint implements two PCI functions.
> 
> The devicetree node describing those functions incorrectly includes
> this property:
> 
>     device_type = "pci";
> 
> That property should only be used for a PCI device "that implements
> a PCI bus", but not a PCIe function.  So remove the device_type
> property from the nodes representing the two embedded PCI functions.
> 
> Additionally, those properties contain #address-cells, #size-cells,
> and ranges properties.  And although these properties *will* be
> appropriate for these functions on an RB3gen2, they are not normally
> used for PCI functions.  So remove these properties as well; we'll
> include them in the commit that actually adds the pci-ep-bus sub-node
> to each of these PCI function nodes.
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Fixes: aa7b4bbcb3a1d ("arm64: dts: qcom: qcs6490-rb3gen2: Add TC9563 PCIe switch node")
> Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>