Re: [PATCH] lib/win_minmax: use /* notation for regular comments

From: Andy Shevchenko

Date: Tue Sep 01 2026 - 03:39:58 EST


On Mon, Jan 02, 2023 at 01:16:14PM -0800, Randy Dunlap wrote:
> Don't use kernel-doc "/**" notation for non-kernel-doc comments.
> Prevents a kernel-doc warning:
>
> lib/win_minmax.c:31: warning: expecting prototype for lib/minmax.c(). Prototype was for minmax_subwin_update() instead

...

> -/**
> +/*
> * lib/minmax.c: windowed min/max tracker

Side note (just stumbled over it today), if you fixing like this it also makes
sense to drop rather problematic filename in the file. Here is exactly a good
example why (it's not the same as on the filesystem and in general easy to go
south with time).

> *
> * Kathleen Nichols' algorithm for tracking the minimum (or maximum)

--
With Best Regards,
Andy Shevchenko