Re: [PATCH v3 0/7] thunderbolt: Fix DP tunnel teardown while an async DPRX read is running

[Mika Westerberg]

Hi,

On Sat, Aug 29, 2026 at 10:08:32AM +0200, Sven Peter wrote:
> Hi,
> 
> This series contains a bunch of fixes related to teardown while an async
> DPRX read is running. I ran into some of these while bringing up the
> Apple Silicon NHI and just haven't implemented DP tunneling support yet
> such that the DPRX capabilities read can never complete and will always
> time out.
> 
> None of it is specific to that hardware though so I figured it
> makes sense to already send them out.
> 
> Best,
> 
> Sven
> 
> ---
> Changes in v3:
> - Take the router references in the HopID allocation/release helpers
> - Actually call put_device() via a cleanup action for the KUnit tests
> - Link to v2: https://patch.msgid.link/20260823-b4-tbt-fixes-v2-0-26a18a426c9f@xxxxxxxxxx
> 
> Changes in v2:
> - Make the DP tunnel activation callback mandatory. The DPRX
>   caps are now always read inside dprx_work which now also happens to
>   discovered tunnels when they are activated again after hibernation
>   restore.
> - Mark discovered tunnels as active
> - Add a cleanup commit to drop the callback data that's always the same now
> - Tear down DP tunnels that are inactive in tb_stop instead of
>   exposing tb_tunnel_cancel_dprx.
> - Use "router" instead of "switch" in the subject
> - Added comments how these issues can be reproduced
> - Link to v1: https://patch.msgid.link/20260817-b4-tbt-fixes-v1-0-eded2461f5fc@xxxxxxxxxx
> 
> To: Andreas Noever <andreas.noever@xxxxxxxxx>
> To: Mika Westerberg <westeri@xxxxxxxxxx>
> To: Yehezkel Bernat <YehezkelShB@xxxxxxxxx>
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Cc: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> Cc: asahi@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> 
> ---
> Sven Peter (7):
>       thunderbolt: Hold a router reference for each allocated HopID
>       thunderbolt: Make the DP tunnel activation callback mandatory
>       thunderbolt: Fix domain reference leak when DPRX read is canceled
>       thunderbolt: Don't access a DP tunnel after its DPRX read was canceled
>       thunderbolt: Mark discovered tunnels as active
>       thunderbolt: Tear down inactive DP tunnels when the domain is stopped

Applied 1-6 to thunderbolt.git/fixes, with minor changes in the commit
messages and the condition in patch 6, thanks! Please check that it is
okay. My testing at least it works as expected.

>       thunderbolt: Drop the DP tunnel activation callback data

Since this one is a cleanup, I wonder if you can send it again later when
the DPRX fixes have landed? I typically base my next branch after -rc1 and
don't merge fixes/rc's there constantly so preferably after v7.4-rc1 is
released.