Re: [PATCH v2] staging: rtl8723bs: convert swing index variables from u8 to int

From: Greg Kroah-Hartman

Date: Tue Sep 01 2026 - 05:57:03 EST


On Tue, Aug 04, 2026 at 10:31:37PM +0530, Mohit Mishra wrote:
> In ODM_TxPwrTrackSetPwr_8723B(), Final_OFDM_Swing_Index and
> Final_CCK_Swing_Index are declared as u8. Using u8 for variables involved
> in arithmetic calculations and lower-bound comparisons (<= 0) is unusual
> and triggers static analysis warnings.

What warnings?

> Convert both variables from u8 to int to clean up the variable types,
> aligning with the TODO item to "convert any remaining unusual variable
> types".

u8 is NOT an unusual variable type at all.

thanks,

greg k-h