Re: [PATCH v2] serial: qcom-geni: Fix port_ida handling for console and probe errors
From: Konrad Dybcio
Date: Tue Sep 01 2026 - 06:22:53 EST
On 8/31/26 5:59 PM, Aniket RANDIVE wrote:
>
>
> On 8/31/2026 5:08 PM, Konrad Dybcio wrote:
>> On 8/31/26 1:12 PM, Aniket Randive wrote:
>>> The console port uses a fixed line number and is not allocated from
>>> port_ida. However, qcom_geni_serial_remove() unconditionally frees the
>>> line number for all ports, including the console port.
[...]
> Thanks for catching this.
>
> Looking closer, this appears to be a separate issue from the port_ida fixes in this patch. The dev_pm_domain_detach_list() problem already exists in the current error path and is not introduced by this change.
>
> Since this involves power-domain cleanup rather than port_ida handling, I'd prefer to address it in a separate follow-up patch to keep this fix focused and easier to review.
>
> Is it OK to keep this patch limited to the port_ida fixes and handle the power-domain cleanup separately?
Yes
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad