Re: [PATCH v3 1/2] dt-bindings: usb: gpio-sbu-mux: Add compatible for FUSB340

[Xu Yang]

Hi Fabrice,

On Tue, Sep 01, 2026 at 10:02:50AM +0200, Fabrice Gasnier wrote:
> On 9/1/26 08:31, Xu Yang wrote:
> > Hi Fabrice,
> > 
> > On Wed, Aug 26, 2026 at 02:16:35PM +0200, Fabrice Gasnier wrote:
> >> Add a compatible for the FUSB340 GPIO-based 2:1 SuperSpeed switch
> >> with enable-gpios and select-gpios controls. The switch can be used
> >> in Type-C applications where a reversible cable requires a switch.
> >>
> >> Suggested-by: Marek Vasut <marex@xxxxxxxxxxxx>
> >> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> >> ---
> >>  Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> >> index 793662f6f3bf..c0e60848d8ab 100644
> >> --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> >> +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> >> @@ -22,6 +22,7 @@ properties:
> >>            - nxp,cbdtu02043
> >>            - onnn,fsusb42
> >>            - onnn,fsusb43l10x
> >> +          - onnn,fusb340
> >>            - pericom,pi3usb102
> >>            - ti,tmuxhs4212
> >>        - const: gpio-sbu-mux
> > 
> > To be honest, the added one is SuperSpeed Line switch. The gpio-sbu-mux.yaml
> > describes SBU line here. They are different. Should another compatible name
> > be created? Such as gpio-ss-mux or similar?
> 
> Hi Xu,
> 
> It is very similar to other parts supported here already (see tmuxhs4212
> datasheet). I don't understand why another compatible would be created ?
> And other properties in the bindings indicate the purpose, e.g.
> mode-switch, orientation-switch.

I suspect tmuxhs4212 intentionally misused "gpio-sbu-mux" as SuperSpeed switch.
Commit 06f49cc255b3 said it's used for SBU lines switching, but actually their
DTBs use it for SuperSpeed lines switching. It's not correct and would confuse
users.

Thanks,
Xu Yang

> 
> BR,
> Fabrice
> 
> > 
> > Thanks,
> > Xu Yang
> > 
> >>
> >> -- 
> >> 2.43.0
> >>
>