Re: [PATCH] ALSA: hda: restore MFG widget enumeration after core split

[Takashi Iwai]

On Tue, 01 Sep 2026 05:40:24 +0200,
raoxu wrote:
> 
> From: Xu Rao <raoxu@xxxxxxxxxxxxx>
> 
> Before commit 7639a06c23c7 ("ALSA: hda - Move a part of hda_codec stuff
> into hdac_device"), widget enumeration selected the function group with
> 
> 	codec->afg ? codec->afg : codec->mfg
> 
> and read subordinate nodes from that group.
> 
> The core split moved this logic into snd_hdac_refresh_widgets(), but
> hard-coded codec->afg there. For an MFG-only codec, codec->afg is zero,
> so the Root Node is queried and codec->start_nid/num_nodes are populated
> from the function-group range instead of the MFG's subordinate nodes.
> 
> Restore the pre-split AFG-or-MFG selection.
> 
> Fixes: 7639a06c23c7 ("ALSA: hda - Move a part of hda_codec stuff into hdac_device")
> Signed-off-by: Xu Rao <raoxu@xxxxxxxxxxxxx>

Thanks, applied now.

(Though, I've never seen an actual hardware with MFG, so it's likely
 no issue in practice :)


Takashi