[PATCH v2] staging: rtl8723bs: avoid CamelCase in rtw_efuse
From: Philip Nielsen
Date: Tue Sep 01 2026 - 06:46:09 EST
Avoid CamelCase naming for local variables, function parameters,
and static helper functions in rtw_efuse.c as well as associated
prototypes in rtw_efuse.h to adhere to the Linux
kernel coding style and clear checkpatch.pl checks.
Signed-off-by: Philip Nielsen <philipnielsen64@xxxxxxxxx>
---
Changes in v2:
- Rebase on top of latest staging-testing branch.
drivers/staging/rtl8723bs/core/rtw_efuse.c | 72 +++++++++----------
drivers/staging/rtl8723bs/include/rtw_efuse.h | 4 +-
2 files changed, 38 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 7e215c9845f6..b2d22307b115 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,48 +41,48 @@ rtw_efuse_calculate_word_counts(u8 word_en)
* 09/23/2008 MHC Copy from WMAC.
*
*/
-u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
+u8 rtw_efuse_read_1_byte(struct adapter *adapter, u16 address)
{
- u8 Bytetemp = {0x00};
+ u8 byte_temp = {0x00};
u8 temp = {0x00};
u32 k = 0;
- u16 contentLen = 0;
+ u16 content_len = 0;
- Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &contentLen);
+ Hal_GetEfuseDefinition(adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &content_len);
- if (Address < contentLen) {/* E-fuse 512Byte */
+ if (address < content_len) {/* E-fuse 512Byte */
/* Write E-fuse Register address bit0~7 */
- temp = Address & 0xFF;
- rtw_write8(Adapter, EFUSE_CTRL + 1, temp);
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 2);
+ temp = address & 0xFF;
+ rtw_write8(adapter, EFUSE_CTRL + 1, temp);
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 2);
/* Write E-fuse Register address bit8~9 */
- temp = ((Address >> 8) & 0x03) | (Bytetemp & 0xFC);
- rtw_write8(Adapter, EFUSE_CTRL + 2, temp);
+ temp = ((address >> 8) & 0x03) | (byte_temp & 0xFC);
+ rtw_write8(adapter, EFUSE_CTRL + 2, temp);
/* Write 0x30[31]= 0 */
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3);
- temp = Bytetemp & 0x7F;
- rtw_write8(Adapter, EFUSE_CTRL + 3, temp);
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 3);
+ temp = byte_temp & 0x7F;
+ rtw_write8(adapter, EFUSE_CTRL + 3, temp);
/* Wait Write-ready (0x30[31]= 1) */
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3);
- while (!(Bytetemp & 0x80)) {
- Bytetemp = rtw_read8(Adapter, EFUSE_CTRL + 3);
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 3);
+ while (!(byte_temp & 0x80)) {
+ byte_temp = rtw_read8(adapter, EFUSE_CTRL + 3);
k++;
if (k == 1000)
break;
}
- return rtw_read8(Adapter, EFUSE_CTRL);
+ return rtw_read8(adapter, EFUSE_CTRL);
} else {
return 0xFF;
}
} /* rtw_efuse_read_1_byte */
-/* 11/16/2008 MH Read one byte from real Efuse. */
+/* 11/16/2008 MH Read one byte from real efuse. */
u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
{
u32 tmpidx = 0;
- u8 bResult;
+ u8 b_result;
u8 readbyte;
/* <20130121, Kordan> For SMIC EFUSE specificatoin. */
@@ -107,19 +107,19 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
}
if (tmpidx < 100) {
*data = rtw_read8(padapter, EFUSE_CTRL);
- bResult = true;
+ b_result = true;
} else {
*data = 0xff;
- bResult = false;
+ b_result = false;
}
- return bResult;
+ return b_result;
}
/*-----------------------------------------------------------------------------
- * Function: Efuse_ReadAllMap
+ * Function: efuse_read_all_map
*
- * Overview: Read All Efuse content
+ * Overview: Read All efuse content
*
* Input: NONE
*
@@ -132,15 +132,15 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
* 11/11/2008 MHC Create Version 0.
*
*/
-static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse)
+static void efuse_read_all_map(struct adapter *padapter, u8 efuse_type, u8 *efuse)
{
- u16 mapLen = 0;
+ u16 map_len = 0;
Hal_EfusePowerSwitch(padapter, true);
- Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen);
+ Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len);
- Hal_ReadEFuse(padapter, efuseType, 0, mapLen, Efuse);
+ Hal_ReadEFuse(padapter, efuse_type, 0, map_len, efuse);
Hal_EfusePowerSwitch(padapter, false);
}
@@ -161,18 +161,18 @@ static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse)
* 11/13/2008 MHC Create Version 0.
*
*/
-void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType)
+void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type)
{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
- u16 mapLen = 0;
+ struct eeprom_priv *eeprom = GET_EEPROM_EFUSE_PRIV(padapter);
+ u16 map_len = 0;
- Hal_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, &mapLen);
+ Hal_GetEfuseDefinition(padapter, efuse_type, TYPE_EFUSE_MAP_LEN, &map_len);
- if (pEEPROM->bautoload_fail_flag)
- memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen);
+ if (eeprom->bautoload_fail_flag)
+ memset(eeprom->efuse_eeprom_data, 0xFF, map_len);
else
- Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data);
+ efuse_read_all_map(padapter, efuse_type, eeprom->efuse_eeprom_data);
/* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */
- /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */
+ /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], map_len); */
} /* rtw_efuse_shadow_map_update */
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index a60e05cf699c..1e5d61f4587b 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -71,7 +71,7 @@ struct efuse_hal {
u8 rtw_efuse_calculate_word_counts(u8 word_en);
u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data);
-u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address);
-void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType);
+u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 address);
+void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuse_type);
#endif
--
2.55.0