Re: [PATCH 2/3] arm64: dts: qcom: add HP OmniBook Ultra 14-kg0xxx

[Konrad Dybcio]

On 8/30/26 11:56 PM, Jason Pettit wrote:
> Add board support for HP OmniBook Ultra 14" Next Gen AI PC
> (product SKU D29KLAS#ABA, board 8F03), a Snapdragon X2 Elite (Glymur)
> laptop, using the "hp,omnibook-ultra-kg0xxx" / "qcom,glymur" compatible.

[...]


> +	sound {
> +		compatible = "qcom,glymur-sndcard";
> +		/* This board reuses GLYMUR-CRD-tplg.bin from linux-firmware */
> +		model = "GLYMUR-CRD";

This should have its own model name, the topology repo has some
existing infra to make reuse easy (aliases in the CMake file)

[...]

> +&gmu {
> +	status = "okay";
> +};

This is already enabled in glymur.dtsi


> +
> +&gpu {
> +	status = "okay";
> +};
> +
> +/* keyboard: HID-over-I2C on i2c0 */

I think we can drop this comment (also a similar one near vreg_l2h_e0_0p88)

[...]

> +&tlmm {
> +	gpio-reserved-ranges = <4 4>,
> +			       <10 2>,
> +			       <44 4>,
> +			       <65 1>,
> +			       <90 1>;

Do we know what these are used for?

[...]

> +/* usb_0: 2nd USB-C port (host + DP alt-mode) */

These comments I also find a little unnecesasry

Konrad