Re: [RFC PATCH v2 11/23] sched/cache: Introduce helpers for task migration decisions

[Peter Zijlstra]

On Thu, Aug 27, 2026 at 08:28:04PM +0800, Jianyong Wu wrote:

> +static bool get_span_stats(const struct cpumask *span, unsigned long *util_out,
> +					unsigned long *cap_out)
> +{
> +	cpumask_var_t mask;
> +	int cpu;
> +	unsigned long util_tmp, cap_tmp, util = 0, cap = 0;
> +	struct sched_domain *sd_tmp;
> +

We prefer inverse xmas ordering -- where possible. So please go through
the code and re-arrange things. Eg. the above becomes:

> +	unsigned long util_tmp, cap_tmp, util = 0, cap = 0;
> +	struct sched_domain *sd_tmp;
> +	cpumask_var_t mask;
> +	int cpu;