Re: [PATCH v7 06/17] drm/panfrost: Consolidate device clock management and reset

[Boris Brezillon]

On Fri, 28 Aug 2026 21:56:46 +0100
Adrián Larumbe <adrian.larumbe@xxxxxxxxxxxxx> wrote:

> Gather all clock enables and disables into a single function to avoid
> repetition. Also, as part of the same function, handle reset control
> (de)assertions, since that was already the case in the PM runtime
> functions.

I think I'd prefer to not mix clks and reset-lines. So basically, a
set of helpers that deals with clks (panfrost_clks_{enable,disable}()),
and manual calls for the reset line.

> 
> Also do clk (un)prepares and dis/enables at the same time, since the
> clk_prepare_* family of functions can simply increase the refcnt of
> an already prepared clock.
> 
> Signed-off-by: Adrián Larumbe <adrian.larumbe@xxxxxxxxxxxxx>