Re: [PATCH v3 1/2] Bluetooth: dt-bindings: net: bluetooth: add BCM4384

[Paul Menzel]

Dear Andy,


Thank you for your patch.

Am 01.09.26 um 10:57 schrieb Andy Chang:
> Add the brcm,bcm4384-bt compatible string to support the
> Synaptics BCM4384 Bluetooth controller.
>
> A fallback compatible is not suitable here because the BCM4384
> controller requires a dedicated firmware patch file (.hcd) matching
> its specific hardware ID and revision.
>
> Falling back to an existing compatible would cause the driver to
> request the wrong firmware binary and fail the controller
> initialization.
>
> Signed-off-by: Andy Chang <andy.chang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>

I’d use your @synaptics.com address.

> ---
> Changes in v3:
>   - Fix typo and GitLint failure.

kaihsin.chung@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx also sent in patches 
[1]. It’d be great if you could coordinate.

>   .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> index 95501e858e6f..612d21123aaa 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> @@ -31,6 +31,7 @@ properties:
>             - brcm,bcm43540-bt
>             - brcm,bcm4335a0
>             - brcm,bcm4349-bt
> +          - brcm,bcm4384-bt
>             - cypress,cyw4373a0-bt
>             - infineon,cyw55572-bt

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul


[1]: 
https://lore.kernel.org/all/?q=kaihsin.chung@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx