Re: [PATCH] tpm: crb: handle ACPI NVS memory region overlap

[Jarkko Sakkinen]

On Tue, Sep 01, 2026 at 03:57:43PM +0300, Jarkko Sakkinen wrote:
> On Fri, Aug 28, 2026 at 07:11:41PM +0800, MicroFish wrote:
> > On Fri, Aug 28, 2026 at 05:04:54AM +0300, Jarkko Sakkinen wrote:
> > 
> > > Cannot and will not move forward given undefined and open set of gear.
> > >
> > > There was also a corrupted email address in the CC list (microfish at
> > > kernel dot org).
> > 
> > Thanks for the review.
> > 
> > The affected hardware I have confirmed is the Lenovo ThinkPad E475
> > with an AMD APU.
> > 
> > This is the platform on which I reproduced the ACPI NVS and TPM CRB
> > MMIO region overlap described in the patch.
> > 
> > The incorrect CC address was my mistake. The correct address is
> > [f13208471983@xxxxxxx](mailto:f13208471983@xxxxxxx).
> > 
> > Best regards,
> > microfish
> > 
> 
> Please only claim what you have quantitative proof for.
> 
> Also this is faulty:
> 
> Signed-off-by: microfish <microfish@xxxxxxxxxx>
> 
> I'm not happy with the code change but I'll try to propose something
> once I have the bandwidth. Need to think about it a bit.

This was the itch:

https://lore.kernel.org/linux-integrity/20260901142955.187856-1-jarkko@xxxxxxxxxx/T/#u

Once that is reviewed and applied you should:

1. Remove crb_try_nvs_fallback
2. Refactor crb_map_res instead.

BR, Jarkko