Re: [PATCH net-next] net: dsa: mxl-gsw1xx: deassert internal PHY resets before MDIO registration

[Andrew Lunn]

> +static int gsw1xx_setup(struct dsa_switch *ds)
> +{
> +	struct gswip_priv *gswip_priv = ds->priv;
> +	struct gsw1xx_priv *priv = container_of(gswip_priv, struct gsw1xx_priv, gswip);
> +	struct device_node *phy_np;
> +	struct dsa_port *dp;
> +	u32 phy_reset_mask = 0;
> +	int ret;

Reverse Christmas tree.

You might want to pass ds->priv to container_of(). Or if this appears
a few times, add something similar to bcm_sf2_to_priv().

    Andrew

---
pw-bot: cr