Re: [PATCH v2 6/6] sched: dynamic: Simplify preempt model accessors

[Mark Rutland]

On Fri, Aug 07, 2026 at 10:00:44AM +0800, Jinjie Ruan wrote:
> 在 2026/8/4 3:17, Mark Rutland 写道:
> >  enum {
> >  	preempt_dynamic_undefined = -1,
> > -	preempt_dynamic_none,
> > -	preempt_dynamic_voluntary,
> >  	preempt_dynamic_full,
> >  	preempt_dynamic_lazy,
> 
> Hi Mark,
> 
> Should the annotations for NONE and VOLUNTARY be removed simultaneously?
> 
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -7788,12 +7788,6 @@ EXPORT_SYMBOL(__cond_resched_rwlock_write);
>  # endif
> 
>  /*
> - * NONE:
> - *   (unselectable)
> - *
> - * VOLUNTARY:
> - *   (unselectable)
> - *
>   * FULL:
>   *   dynamic_preempt_lazy       <- false
>   *

I had left those lines to indicate that those modes were deliberately not
selectable with preempt_dynamic. Evidently keeping them was confusing,
so I'll delete them.

> Otherwise, LGTM
> Reviewed-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

Thanks!

Mark.

> >  };
> > @@ -7889,8 +7887,6 @@ static void __init preempt_dynamic_init(void)
> >  	}								\
> >  	EXPORT_SYMBOL_GPL(preempt_model_##mode)
> >  
> > -PREEMPT_MODEL_ACCESSOR(none);
> > -PREEMPT_MODEL_ACCESSOR(voluntary);
> >  PREEMPT_MODEL_ACCESSOR(full);
> >  PREEMPT_MODEL_ACCESSOR(lazy);
> >  
>