[PATCH v3 0/3] Fix CS35L56 amplifier on Intel LPSS SPI with broken ACPI cs-gpios

From: Khalil

Date: Tue Sep 01 2026 - 15:57:10 EST


v3 of the patch series fixing dual CS35L56 amplifiers on HP laptops
with Intel Lunar Lake and broken ACPI cs-gpios.

Changes since v2:
- Rebased onto broonie/spi for-next (commit b00c00f7dc)
- No code changes

Changes since RFC v1 (addressing feedback from Richard Fitzgerald):
- Added DMI quirk table: GPIO CS fixup is now only applied on known
affected platforms (HP EliteBook 8 G1i, board 8D8A), not generically
for all devices with CS > 0.
- Fixed chip select range check: only chip selects outside the
controller's num_chipselect range are fixed up. A NULL cs_gpiods[cs]
within range means "native chip select", not broken.
- Removed ASUS reference (GU605C was fixed by BIOS update).
- Added Patch 1/3 (spi core): __spi_add_device() now preserves preset
cs_gpiod on the device instead of unconditionally overwriting from
ctlr->cs_gpiods. Suggested by Richard Fitzgerald.
- Patch 2/3 (serial-multi-instantiate): Extracted GPIO fixup into a
dedicated helper function with DMI-based quirk table.
- Patch 3/3 (spi-pxa2xx): Handles clock gating on Intel LPSS
controllers when GPIO chip select is active.

Tested on HP EliteBook 8 G1i 16 inch (Intel Core Ultra 7 258V,
Lunar Lake-M) with 2x CS35L56 Rev B0. Both amplifiers probe
successfully, load calibration and tuning, and produce audio.

Related bug reports:
- https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/2131138
- https://bugzilla.kernel.org/show_bug.cgi?id=221064
- https://github.com/thesofproject/linux/issues/5621

Khalil (3):
spi: Preserve preset cs_gpiod in __spi_add_device()
platform/x86: serial-multi-instantiate: Fix SPI chip select on
platforms with incomplete ACPI cs-gpios
spi: pxa2xx: Handle clock gating for GPIO chip select devices

.../platform/x86/serial-multi-instantiate.c | 168 ++++++++++++++++++
drivers/spi/spi-pxa2xx.c | 45 ++++-
drivers/spi/spi.c | 3 +-
3 files changed, 211 insertions(+), 5 deletions(-)

--
2.43.0