Re: [PATCH net] bnxt_en: Prevent queue stop with deferred completions
From: Jakub Kicinski
Date: Tue Sep 01 2026 - 19:49:53 EST
On Thu, 27 Aug 2026 16:02:32 -0700 Joe Damato wrote:
> When the driver receives a burst of packets, it can mark a BD with the
> NO_CMPL bit to defer completions. The expectation is that the last
> packet in the ring will have this bit unset and the completion generated
> by that packet will cleanup that packet and the ones preceding it. This
> helps to reduce the number of completions fired.
AI points out that the DMA map etc. path does not obey the new
kick_prod that you're adding. TBH the checks you're adding look
quite messy. You should try to fix this by centralizing the kick /
flush logic at the end of bnxt_start_xmit() ?
Maybe bnxt_sw_udp_gso_xmit() should be returning int 1/0/-1 that
you can then interpret in the caller instead or some such.
--
pw-bot: cr