[PATCH 14/14] ASoC: rt5665: return cache sync errors from resume

From: Pengpeng Hou

Date: Tue Sep 01 2026 - 21:34:29 EST


rt5665_resume() restores cached registers during component resume but
discards the regcache_sync() result and returns success. A failed replay
can therefore leave the hardware register state stale without reaching
the component error reporting path.

Return the cache synchronization result. The ASoC component wrapper
reports a negative callback result and retains the established
best-effort resume state, so this adds observability without introducing
rollback or retry semantics.

The successful resume path is unchanged.

The issue was found by a tool we developed.

Fixes: 33ada14a26c8 ("ASoC: add rt5665 codec driver")
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
---
sound/soc/codecs/rt5665.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c
index 1d987472ba42..6e4967ed12c3 100644
--- a/sound/soc/codecs/rt5665.c
+++ b/sound/soc/codecs/rt5665.c
@@ -4388,9 +4388,7 @@ static int rt5665_resume(struct snd_soc_component *component)
struct rt5665_priv *rt5665 = snd_soc_component_get_drvdata(component);

regcache_cache_only(rt5665->regmap, false);
- regcache_sync(rt5665->regmap);
-
- return 0;
+ return regcache_sync(rt5665->regmap);
}
#else
#define rt5665_suspend NULL
--
2.50.1 (Apple Git-155)