[PATCH 04/14] ASoC: es8323: return cache sync errors from resume

From: Pengpeng Hou

Date: Tue Sep 01 2026 - 21:35:32 EST


es8323_resume() restores cached registers during component resume but
discards the regcache_sync() result and returns success. A failed replay
can therefore leave the hardware register state stale without reaching
the component error reporting path.

Return the cache synchronization result. The ASoC component wrapper
reports a negative callback result and retains the established
best-effort resume state, so this adds observability without introducing
rollback or retry semantics.

The successful resume path is unchanged.

The issue was found by a tool we developed.

Fixes: b97391a604b9 ("ASoC: codecs: Add support for ES8323")
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
---
sound/soc/codecs/es8323.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/es8323.c b/sound/soc/codecs/es8323.c
index b926340256be..03d516d70c43 100644
--- a/sound/soc/codecs/es8323.c
+++ b/sound/soc/codecs/es8323.c
@@ -733,9 +733,7 @@ static int es8323_resume(struct snd_soc_component *component)
struct es8323_priv *es8323 = snd_soc_component_get_drvdata(component);

regcache_cache_only(es8323->regmap, false);
- regcache_sync(es8323->regmap);
-
- return 0;
+ return regcache_sync(es8323->regmap);
}

static const struct snd_soc_component_driver soc_component_dev_es8323 = {
--
2.50.1 (Apple Git-155)