Re: [PATCH] mm/migrate_device: fix function name in kernel-doc

[Zi Yan]

On Tue Sep 1, 2026 at 2:51 AM EDT, zhaozhengzhuo wrote:
> The kernel-doc for migrate_device_range() says that migrate_vma_setup()
> is similar to itself.  Refer to migrate_device_range() as the subject of
> the comparison, making the distinction between virtual-address-based and
> device-PFN-based migration clear.
>
> Fixes: e778406b40db ("mm/migrate_device.c: add migrate_device_range()")
> Signed-off-by: zhaozhengzhuo <zhaozhengzhuo@xxxxxxxxxxxxx>
> ---
>  mm/migrate_device.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/migrate_device.c b/mm/migrate_device.c
> index 009bfa8b212d..4a614a3488ed 100644
> --- a/mm/migrate_device.c
> +++ b/mm/migrate_device.c
> @@ -1398,9 +1398,9 @@ static unsigned long migrate_device_pfn_lock(unsigned long pfn)
>   * @start: starting pfn in the range to migrate.
>   * @npages: number of pages to migrate.
>   *
> - * migrate_vma_setup() is similar in concept to migrate_vma_setup() except that
> - * instead of looking up pages based on virtual address mappings a range of
> - * device pfns that should be migrated to system memory is used instead.
> + * migrate_device_range() is similar in concept to migrate_vma_setup(), except
> + * that instead of looking up pages based on virtual address mappings a range
> + * of device pfns that should be migrated to system memory is used instead.

While at it, can you also drop the last instead? Since the sentence is

... instead of ... instead.

>   *
>   * This is useful when a driver needs to free device memory but doesn't know the
>   * virtual mappings of every page that may be in device memory. For example this

With that fixed, feel free to add:

Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>

Thanks.


-- 
Best Regards,
Yan, Zi