Re: [PATCH] spi: sh-msiof: propagate setup runtime-PM errors
From: Geert Uytterhoeven
Date: Wed Sep 02 2026 - 03:23:57 EST
On Sun, 30 Aug 2026 at 16:10, Pengpeng Hou <pengpeng@xxxxxxxxxxx> wrote:
> sh_msiof_spi_setup() ignores pm_runtime_get_sync() before programming
> native chip-select registers and marking the configuration initialized.
>
> Use the checked runtime-PM helper and return failure before register
> access.
>
> Fixes: 7ff0b53c4051 ("spi: sh-msiof: Avoid writing to registers from spi_master.setup()")
FTR, this is the wrong commit, please follow moved code.
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds