Re: [PATCH v7 11/23] KVM: arm64: Share arm64 code with s390

[Marc Zyngier]

On Tue, 01 Sep 2026 09:40:37 +0100,
Steffen Eiden <seiden@xxxxxxxxxxxxx> wrote:
> 
> On Tue, Sep 01, 2026 at 09:13:56AM +0100, Marc Zyngier wrote:
> > Why the exit handler, and not the EC handlers aside from the UNKNOWN
> > one? Yes, you probably aren't there yet in this series, but I can tell
> > you are going to add more and more of these.
> > 
> > But the EC array is absolutely architectural, and there is no good
> > reason to maintain your own.
> > 
> > So instead of this, why not keep the EC array altogether, and
> > implement stubs for the ECs you don't support?
> > 
> > 	M.
> > 
> 
> There was no specific reasson to define our own EC array as far as I
> remember. I will try reusing the array and find out if there are any
> issues with that. But I do not expect any. 
> 
> I assume the stubs probably just forward to handle_unknown_ec, or do you
> have a different suggestion?

Probably. This is an indication of something being deeply wrong in the
implementation (HW or SW). On reflection, kvm_handle_unknown_ec()
should result in a KVM_BUG().

	M.

-- 
Jazz isn't dead. It just smells funny.