Re: [PATCH v16 00/22] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers

From: Niklas Söderlund

Date: Wed Sep 02 2026 - 04:51:32 EST


On 2026-09-01 10:43:44 +0300, Tomi Valkeinen wrote:
> Hi,
>
> On 01/09/2026 10:39, Ceclan Dumitru wrote:
> >
> >
> > On 8/31/26 8:03 PM, Niklas Söderlund wrote:
> > > Hello,
> > >
> > > Thanks for your continued effort pushing this work forward!
> > >
> > > On 2026-08-31 16:21:19 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > > This series adds new drivers for multiple Maxim GMSL2 and GMSL3 devices,
> > > > replacing the few GMSL2 drivers already in upstream, and introducing a
> > > > common framework that can be used to implement such GMSL chips, which
> > > > avoids code duplication while also adding support for previously
> > > > unsupported features.
> > > >
> > > > While the normally acceptable and polite way would be to extend the
> > > > current mainline drivers, the choice was made here to add a totally new
> > > > set of drivers. The current drivers support only a small subset of the
> > > > possible features, and only a few devices, so the end result after
> > > > extending them would in any case be essentially fully rewritten, new
> > > > drivers.
> > > >
> > > > This series depends on support for internal pads, for which a patch has
> > > > been added.
> > >
> > > It also depends on enabling the streams API right? At least I need to do
> > > so to be able to use the TPG. Out of curiosity do you know the plan to
> > > enable it by default upstream?
> > >
> >
> > I do not know when default enable is planned, but series could make it
> > so VIDEO_MAXIM_SERDES selection causes v4l2_subdev_enable_streams_api=1.
> > I am not sure that such a hack would be acceptable by Sakari or
> > upstream in general.
> I haven't tested with this driver, but in theory these kind of drivers
> should work with the Streams API still disabled. The Streams API is a uAPI,
> so the driver itself works without it. If the default routing for the
> drivers provides a sensible single route, one can use the drivers with a
> single camera. This is what the FPD-Link drivers do (although it's been a
> long time since I verified it with Streams API disabled).

Indeed, but to enable the TPG I need to non-default routing ;-) Nothing
big I'm just impatient for the streams API to be enabled by default in
general.

>
> Tomi
>

--
Kind Regards,
Niklas Söderlund